Skip to content

Update bundled musl to 1.2.5 #142682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update bundled musl to 1.2.5 #142682

wants to merge 2 commits into from
+53 −53

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Jun 18, 2025 •
edited
Loading

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

This is a rebase of

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025

The previous PR stalled out on concerns of ecosystem breakage, but see this comment for @est31 concluding we can move forward without further mitigation: #125692 (comment)

@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025 •
edited
Loading

I would like to nominate this for FCP or whatever the current process is to land these kinds of major toolchain changes.

Landing this update is expected to resolve ongoing issues in the ecosystem with rootless docker images.

I've also drafted a rust-lang blogpost announcing this change (based on the previous musl update's post).

@jieyouxu
Copy link
Member

jieyouxu commented Jun 18, 2025 •
edited
Loading

The process for bumping the target baseline of Tier 2 targets is currently a Major Change Proposal + FCP (see Changing target baseline (e.g. minimum Darwin or Windows version bump) part). If you draft an MCP, I'll help with the notifying relevant target maintainers part.

Changing target baseline (e.g. minimum Darwin or Windows version bump)

  • Propose using: MCP
  • Approve using: FCP
  • Write an MCP describing why the target should have a change of baseline and once discussion has concluded, an FCP can be started to approve the change of baseline.

@jieyouxu jieyouxu added the needs-mcp This change is large enough that it needs a major change proposal before starting work. label Jun 18, 2025
@jieyouxu
Copy link
Member

r? @wesleywiser (since you've reviewed the previous attempt)

@rustbot rustbot assigned wesleywiser and unassigned BoxyUwU Jun 18, 2025
@est31 est31 mentioned this pull request Jun 18, 2025
Closed
@Gankra Gankra mentioned this pull request Jun 18, 2025
Open
3 tasks
@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025

I have filed an MCP:

@jieyouxu jieyouxu removed the needs-mcp This change is large enough that it needs a major change proposal before starting work. label Jun 18, 2025
@est31 est31 added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 18, 2025
@rustbot rustbot mentioned this pull request Jun 18, 2025
Open
@Noratrieb Noratrieb added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jun 18, 2025
@Gankra Gankra mentioned this pull request Jun 18, 2025
Open
@workingjubilee
Copy link
Member

Building host compiler plus musl stds for crater run.

@bors try

bors added a commit that referenced this pull request Jun 19, 2025
@bors
Auto merge of #142682 - Gankra:update_musl_1.2.5, r=<try>
1271e16 
Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

[musl releases page](https://musl.libc.org/releases.html)

Prior update: #107129

MCP for this change: rust-lang/compiler-team#887

--------

This is a rebase of

* #125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Jun 19, 2025

⌛ Trying commit 1926e11 with merge 1271e16...

@bors
Copy link
Collaborator

bors commented Jun 19, 2025

💥 Test timed out

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@workingjubilee
Copy link
Member

@bors2 delegate=try

@craterbot

This comment was marked as duplicate.

Sign in to view
@workingjubilee

This comment was marked as duplicate.

Sign in to view
@craterbot

This comment was marked as duplicate.

Sign in to view
@workingjubilee
Copy link
Member

@craterbot run mode=build-and-test name=musl_upgrade_1_2_5_with_libc_patch_0 start=try#8de4c7234dd9b97c9d76b58671343fdbbc9a433e+target=x86_64-unknown-linux-musl end=try#c066bf6804adc55193b71afdff6a56922f4a8689+target=x86_64-unknown-linux-musl+patch=libc=[email protected]:rust-lang/libc=libc-0.2 crates=https://gist.githubusercontent.com/workingjubilee/075aa4757096ce213b76d576f2f92742/raw/8f14d9616d31e84bbd74ab7deec0a1c314442aae/musl-1_2_5-retry-list-2.txt

@craterbot
Copy link
Collaborator

👌 Experiment musl_upgrade_1_2_5_with_libc_patch_0 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2025
@RalfJung RalfJung mentioned this pull request Jun 29, 2025
Open
@craterbot
Copy link
Collaborator

🚧 Experiment musl_upgrade_1_2_5_with_libc_patch_0 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment musl_upgrade_1_2_5_with_libc_patch_0 is completed!
📊 0 regressed and 0 fixed (144410 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 29, 2025
@Skgland
Copy link
Contributor

Skgland commented Jun 29, 2025

Mostly broken crates, with a broken cargo.toml in the try run. Looks like the patch didn't work for some reason.

@workingjubilee
Copy link
Member

I forgot I was supposed to patch getrandom and not libc. :V

@workingjubilee

This comment was marked as duplicate.

Sign in to view
@craterbot

This comment was marked as duplicate.

Sign in to view
@workingjubilee
Copy link
Member

grrh.

@workingjubilee

This comment was marked as duplicate.

Sign in to view
@craterbot

This comment was marked as duplicate.

Sign in to view
@workingjubilee

This comment was marked as duplicate.

Sign in to view
@craterbot

This comment was marked as duplicate.

Sign in to view
@workingjubilee
Copy link
Member

@craterbot run mode=build-and-test name=musl_upgrade_1_2_5_with_getrandom_patch_0 start=try#8de4c7234dd9b97c9d76b58671343fdbbc9a433e+target=x86_64-unknown-linux-musl end=try#c066bf6804adc55193b71afdff6a56922f4a8689+target=x86_64-unknown-linux-musl+patch=getrandom=[email protected]:rust-random/getrandom=backports/v0.2 crates=https://gist.githubusercontent.com/workingjubilee/075aa4757096ce213b76d576f2f92742/raw/197ec4b1e9a09e208b6863172f6a1e9baceaa842/musl-1_2_5-retry-list-4.txt

@craterbot
Copy link
Collaborator

👌 Experiment musl_upgrade_1_2_5_with_getrandom_patch_0 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment musl_upgrade_1_2_5_with_getrandom_patch_0 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Skgland
Copy link
Contributor

Skgland commented Jun 30, 2025 •
edited
Loading

Mostly broken crates, with a broken cargo.toml in the try run. Looks like the patch didn't work for some reason.

I forgot I was supposed to patch getrandom and not libc. :V

I meant the patch caused the Cargo.toml to be invalid, not that the patch was ineffective.
I don't think cargo accepts a git url like that. (rust-lang/cargo#13549)

I think it needs to be

+patch=getrandom=ssh://[email protected]/rust-random/getrandom=backports/v0.2

instead of

[email protected]:rust-random/getrandom=backports/v0.2

Note: the ssh:// protocol and the / instead of : before the path.

@craterbot
Copy link
Collaborator

🎉 Experiment musl_upgrade_1_2_5_with_getrandom_patch_0 is completed!
📊 0 regressed and 0 fixed (144400 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.